Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: use responsible document a little less #4394

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 26, 2019

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@@ -91741,8 +91741,8 @@ document.body.appendChild(frame)</code></pre>
than 0, then throw an <span>"<code>InvalidStateError</code>"</span>
<code>DOMException</code>.</p></li>

<li><p>Let <var>entryDocument</var> be the <span>responsible document</span> specified by the
<span>entry settings object</span>.</p></li>
<li><p>Let <var>entryDocument</var> be <span>entry global object</span>'s <span
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the" entry global object, I think

@annevk annevk merged commit 7ba9854 into master Feb 26, 2019
@annevk annevk deleted the annevk/remove-responsible-document-a-bit branch February 26, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants